-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: styles for tables in SQL lessons #10
Conversation
Previously: table cells had no padding, which caused a visual collapse (cell content was too close to cell neighbors). Table header rows had dark blue background and black letters. Tables had no space between them and following paragraphs. Changes: * added 5px padding to cell contents * changed header row background to gray-ish (I considered switching text color to white, but it didn't look good) * 15px margin on the bottom of the tables (similarly to bottom margin used by paragraph style).
@pbanaszkiewicz What about use the same style from the table at our workshop template, see https://swcarpentry.github.io/workshop-template/? You should keep the change for the table head. |
@r-gaia-cs thanks for suggestion. I was considering a switch to Bootstrap styles, but I don't entirely like them:
If you have specific styles in mind that we can borrow (big padding, no background for |
@pbanaszkiewicz I'm OK with the currently horizontal padding and agree to avoid playing a lot with
and
This samples need improvements to be more robust. |
Now the style is matching closely `.table-bordered` from Bootstrap. I decided to leave the header row background blank because it was too close in color to `#F9F9F9` - our new rule for even rows in the table. I also increased horizontal padding by 5px on both sides, because now that we have vertical borders it was too cramped. Additionaly I introduced borders for every cell in the table.
Hi @r-gaia-cs, It's matching closely I also increased horizontal padding by 5px on both sides, because now that we have vertical borders it was too cramped. |
Fix: styles for tables in SQL lessons
…-slideshow Removing motivational slideshow
translate 'cite' to 'cita'
This PR addresses #9.
Previously
BEFORE:
![screenshot from 2015-02-13 20 46 42](https://cloud.githubusercontent.com/assets/72821/6194287/4ce486c2-b3c3-11e4-8235-1322837291b3.png)
Changes
AFTER:
![screenshot from 2015-02-13 20 51 07](https://cloud.githubusercontent.com/assets/72821/6194298/72854cfe-b3c3-11e4-9b93-33c390c830b9.png)