New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lesson_check.py: use proper regex for matching episode files #615

Merged

maxim-belkin merged 1 commit into carpentries:gh-pages from maxim-belkin:use-proper-regex

Jul 12, 2021

Contributor

maxim-belkin commented Jul 10, 2021

Currently used regex does not match episode filenames for two reasons:

Missing ./ in the beginning of the filenames
CHECKERS contain regex-es, not patterns, so * is a modifier for the previous character and not 'match-anything' kind of thing.

As a result, all episode files were checked using CheckGeneric class and not the CheckEpisode one.

Tangentially related to #611


          lesson_check.py: use proper regex for matching episode files

19dc8e3

maxim-belkin merged commit 14d7356 into carpentries:gh-pages

maxim-belkin deleted the use-proper-regex branch

July 12, 2021 12:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment