Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix how contact email addresses are added to workshop metadata #633

Closed
fmichonneau opened this issue Nov 10, 2019 · 2 comments
Closed

fix how contact email addresses are added to workshop metadata #633

fmichonneau opened this issue Nov 10, 2019 · 2 comments
Labels
status:need more info More information needed

Comments

@fmichonneau
Copy link
Contributor

see carpentries/amy#1568
@fmichonneau fmichonneau changed the title contact should be a single email address fix how contact email addresses are added to workshop metadata Dec 12, 2019
@fmichonneau
Copy link
Contributor Author

Currently, the email addresses provided are merged into a single string in the website metadata see https://github.com/carpentries/workshop-template/blob/gh-pages/_layouts/workshop.html#L22

2 possible implementations:

  • separate the email addresses with a , assuming that AMY can parse that
  • subset the email addresses to only include the first one in the meta data

@fmichonneau fmichonneau added the status:need more info More information needed label Dec 12, 2019
@fmichonneau
Copy link
Contributor Author

fixed with 0594d9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:need more info More information needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fmichonneau