Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor quickxml #7

Merged
merged 13 commits into from Nov 13, 2020
Merged

Refactor quickxml #7

merged 13 commits into from Nov 13, 2020

Conversation

carrascomj
Copy link
Owner

@carrascomj carrascomj commented Nov 13, 2020 •
edited

Related #6

Description

Move from roxmltree to quick-xml.

TODO

  • Move to quick-xml.
  • Mattml: it is a problem since that module relies on roxmltree and doesn't implement Deserialize.
  • PyO3.

@codecov-io
Copy link

codecov-io commented Nov 13, 2020 •
edited

Codecov Report

Merging #7 (b09481a) into trunk (e245a83) will decrease coverage by 21.97%.
The diff coverage is 56.52%.

Impacted Files Coverage Δ
src/pyo.rs 0.00% <0.00%> (ø)
src/model.rs 65.38% <63.15%> (-5.55%) ⬇️
src/lib.rs 100.00% <100.00%> (ø)

@carrascomj carrascomj merged commit 06b1acb into trunk Nov 13, 2020
@carrascomj carrascomj mentioned this pull request Nov 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carrascomj @codecov-io