Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for carrierwave 1.0 #172

Closed
rmm5t opened this issue Jan 3, 2017 · 7 comments
Closed

Add support for carrierwave 1.0 #172

rmm5t opened this issue Jan 3, 2017 · 7 comments

Comments

@rmm5t
Copy link
Member

rmm5t commented Jan 3, 2017

carrierwave 1.0 was released on Christmas Eve.

Pull-requests are very welcome here.

@ivanovaleksey
Copy link
Contributor

Hi @rmm5t,
I tried to create a PR but I am not sure is it enough...
Any comments are welcome.

@rmm5t
Copy link
Member Author

rmm5t commented Jan 13, 2017

@ivanovaleksey Thanks. There's now a new branch named carrierwave-1.0-support so that we can work toward carrierwave 1.0 compatibility. It incorporates your PR, and I've also adde some CI config cleanup (eb01549) so we can better focus the red vs green builds.

IMPORTANT NOTE: The carrierwave-1.0-support branch is not ready for production. It is merely a work-in-progress branch.

@cmavromoustakos
Copy link

Has support for this gem been disncontinued? I am trying to upgrade to rails5.1 and the later carrier wave and just came across this.

Is there anything I can help with?

@rmm5t
Copy link
Member Author

rmm5t commented Jun 19, 2017

@cmavromoustakos I think I'm the only one maintaining this gem, but I don't have any Rails 5.1 projects that use Mongo at the moment. Happy to review pull-requests.

@Startouf
Copy link

Hello, I have a Rails 5.0 app and I'd be happy to help with support for 1.0 carrierwave as I seem to have some bugs with Carrierwave that may be resolved with 1.0. What's the current status @rmm5t ?

@rmm5t
Copy link
Member Author

rmm5t commented Oct 15, 2017

@Startouf Thanks for the offer. I've been busy with client work over the past few months, but things have slowed down a bit in the short-term. I had carrierwave-mongoid on my todo list a month or so ago, but then forgot to pick it up when things slowed down, so thank you for the nudge.

Help with PRs and help reviewing and testing existing PRs would be much appreciated.

@rmm5t rmm5t closed this as completed in e566c59 Oct 15, 2017
@rmm5t
Copy link
Member Author

rmm5t commented Oct 16, 2017

carrierwave-mongoid v1.0.0 was just released with carrierwave 1.x support:
https://rubygems.org/gems/carrierwave-mongoid/versions/1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants