Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against carrierwave v0.10.0 #162

Merged

Conversation

tonyta
Copy link
Contributor

@tonyta tonyta commented May 24, 2016

This gem is green when specs are run against the latest carrierwave published: v0.11.2.

@rmm5t stated in #158 that:

We're not releasing an official version until we fully support the new features in carrierwave v0.11.0. Specifically mount_uploaders.

However, though #mount_uploaders is a feature on carrierwave master, it still remains unreleased in the recently published versions of carrierwave, including v0.11.0.

I'm adding travis tests against carrierwave ~> v0.11.0 in this PR in the hopes that we can reconsider publishing a new version of carrierwave-mongoid, as is.

I apologize in advance if there is something here that I've misunderstood or am missing 馃槄. Beyond that, I'd love to lend a hand to get a passing build with parity to features in carrierwave master, especially #mount_uploads.

馃挍馃挌馃挋馃挏鉂わ笍

@rmm5t
Copy link
Member

rmm5t commented May 24, 2016

This is clean and you have the right idea, but we need to add an extra carrierwave-0.10.gemfile instead. The core Gemfile in the build matrix is already testing the carrierwave v0.11.

If you can switch this to add 0.10 to the build matrix, I'll get this pulled in soon after.

Also, given that no one has yet stepped up to implement #mount_uploaders, I'll concede my original goals and release a new version of carrierwave-mongoid without that feature. It sounds like there are enough people who want to use the latest carrierwave minus that feature anyway.

@tonyta tonyta force-pushed the test-against-carrierwave-0.11 branch from 24dea4b to ac4a988 Compare May 24, 2016 20:37
@tonyta tonyta changed the title Test against carrierwave v0.11.0 Test against carrierwave v0.10.0 May 24, 2016
@tonyta
Copy link
Contributor Author

tonyta commented May 24, 2016

Fixed! Thanks @rmm5t!

The main reason we want to use ~> v0.11.1 is this change: https://github.com/carrierwaveuploader/carrierwave/pull/1925/files
We've been using a fork from v0.10.0 for a while and would like to point carrierwave back to an official release. I appreciate it! 馃樃

I'll take a stab at #mount_uploaders this weekend since there doesn't seem to be too much activity around it since April. Do you know when carrierwave plans to have their next major release?

@rmm5t rmm5t merged commit e2bab91 into carrierwaveuploader:master May 24, 2016
@rmm5t
Copy link
Member

rmm5t commented May 24, 2016

Great. Thanks! :beers

Do you know when carrierwave plans to have their next major release?

Sorry. No idea. That team works separately.

@rmm5t
Copy link
Member

rmm5t commented May 29, 2016

  • carrierwave-mongoid v0.9.0 is now officially released with carrierwave v0.11 support.
  • Note: This release does not yet include mount_uploaders support. Waiting on a viable PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants