Skip to content

Commit

Permalink
allow remove_image to be cancelled
Browse files Browse the repository at this point in the history
  • Loading branch information
rajyan committed Sep 24, 2023
1 parent 8066ebc commit cfaf173
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/carrierwave/mounter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def blank?

def remove=(value)
@remove = value
write_temporary_identifier if remove?
write_temporary_identifier
end

def remove?
Expand Down
2 changes: 1 addition & 1 deletion lib/carrierwave/uploader/store.rb
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def store!(new_file=nil)
end
@file = new_file
@identifier = storage.identifier
@cache_id = @deduplication_index = nil
@original_filename = @cache_id = @deduplication_index = nil
@staged = false
end
end
Expand Down
22 changes: 22 additions & 0 deletions spec/orm/activerecord_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,17 @@ def monkey
expect(@event.image_identifier).to eq(nil)
end

it "should cancel removing image if remove_image is switched to false" do
@event.image = stub_file('test.jpeg')
@event.save!
@event.remove_image = true
@event.remove_image = false
@event.save!
@event.reload
expect(@event[:image]).to eq('test.jpeg')
expect(@event.image_identifier).to eq('test.jpeg')
end

it "should mark image as changed when saving a new image" do
expect(@event.image_changed?).to be_falsey
@event.image = stub_file("test.jpeg")
Expand Down Expand Up @@ -1394,6 +1405,17 @@ def monkey
expect(@event.images_identifiers[0]).to eq(nil)
end

it "should cancel removing images if remove_images is switched to false" do
@event.images = [stub_file('test.jpeg')]
@event.save!
@event.remove_images = true
@event.remove_images = false
@event.save!
@event.reload
expect(@event[:images]).to eq(['test.jpeg'])
expect(@event.images_identifiers[0]).to eq('test.jpeg')
end

it "should mark images as changed when saving a new images" do
expect(@event.images_changed?).to be_falsey
@event.images = [stub_file("test.jpeg")]
Expand Down

0 comments on commit cfaf173

Please sign in to comment.