Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: allow versions redefine #1505

Closed
kuraga opened this issue Nov 22, 2014 · 4 comments
Closed

Suggestion: allow versions redefine #1505

kuraga opened this issue Nov 22, 2014 · 4 comments
Labels
suggestion

Comments

@kuraga
Copy link
Contributor

kuraga commented Nov 22, 2014

According to now we can't redefine versions. So I can't redefine a version in a subclass uploader. I think it breaks inheritance idea.

What about to change this convention?
P.S. Also this is a workaround for #1495 .

Thanks.
@bensie bensie closed this as completed Mar 3, 2015
@bensie
Copy link
Member

bensie commented Mar 4, 2015

Sorry @kuraga! Didn't mean to close without comment.

I'm not opposed to changing that to remove the unless versions[name]. Just need to make sure it doesn't break anything else. Care to work up a pull request?

/cc @taavo

@bensie bensie reopened this Mar 4, 2015
@plribeiro3000
Copy link
Member

@kuraga Since you already did some code research, could you take a stab and open a PR for this?

@kuraga
Copy link
Contributor Author

kuraga commented Jun 9, 2015

After research: sorry, it's not an issue. Test like this has been green already. I'm sorry.

@kuraga kuraga closed this as completed Jun 9, 2015
@mhluska
Copy link
Contributor

mhluska commented Jan 25, 2018

But what if instead of overriding you want to extend?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bensie @plribeiro3000 @mhluska @kuraga @avgerin0s