Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip loading RMagick if already loaded #1346

Merged

Conversation

mshibuya
Copy link
Member

In a case-insensitive filesystem environment, there is a possibility that RMagick gets loaded twice(require 'rmagick' and require 'RMagick' loads the same file, but Ruby sees them as different ones).
This PR solves it by loading RMagick only if needed.

Refs #1205, #1330

@Bodacious
Copy link

+1

@davidbegin
Copy link

+1 this fixed the double load problem I was having.

bensie added a commit that referenced this pull request Apr 3, 2014
@bensie bensie merged commit c0bb87f into carrierwaveuploader:master Apr 3, 2014
@jaredbeck
Copy link
Contributor

It looks like this hasn't been released yet?

git describe --exact-match c0bb87f2ab9b4f1ae94cc622923567690c70c840
fatal: no tag exactly matches 'c0bb87f2ab9b4f1ae94cc622923567690c70c840'

Is there an ETA on the next release? Thanks @mshibuya @bensie for fixing it.

@jaredbeck
Copy link
Contributor

One week ping for @bensie: can we get a release with this fix? Maybe 0.10.1?

@bensie
Copy link
Member

bensie commented May 5, 2014

@jaredbeck Please just use master from Bundler. We'll get a release out as soon as we can.

@jaredbeck
Copy link
Contributor

Please just use master from Bundler. We'll get a release out as soon as we can.

Will do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants