Do not display rmagick exception in I18n message #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instance, if you upload a text file with a JPG extension, rmagick generate an exception, whose message contains the full path of your project directory. It seems to me that it's a security issue, since the generated message displayed to the frontoffice user contains the server project directory. I didn't test other cases (for the orher messages), but potentially this problem can appear somewhere else
bensie
added a commit
that referenced
this pull request
Nov 19, 2014
Do not display rmagick exception in I18n message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, if you upload a text file with a JPG extension, rmagick generate an exception, whose message contains the full path of your project directory. It seems to me that it's a security issue, since the generated message displayed to the frontoffice user contains the server project directory.
I didn't test other cases (for the orher messages), but potentially this problem can appear somewhere else