Fix cache workfile collision between versions #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a major bug. Versioning is broken when using fog as cache-storage and using >1 versions. Your fix works for me but might require a test before being pulled in. |
|
Any ideas how, under the fog tests perhaps? Or just a test that checks the workfile path itself? |
|
I changed the fix slightly (the |
|
CC @bensie |
|
@bensie What is missing before this can be merged in? |
bensie
added a commit
that referenced
this pull request
Aug 21, 2014
Fix cache workfile collision between versions
|
Merged...looks good! |
|
@jvdp Just got exactly same issue and your fix saved lots of my time, thanks! |
|
@mshibuya great to hear that it works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After struggling with this for quite a few hours, it turns out that the changes to the cache from #1312 are not versions aware: during caching, different versions share the same workfile which gets deleted in between. Effectively, this breaks cache use for uploaders with two versions or more.
This patch ensures each version creates its own workfile. There are probably still problems if
move_to_cacheis defined as true, and perhaps this issue can also be solved by somehow sharing workfiles without deleting until all are done with it... The problem also does not seem to occur if thefilestorage mechanism is used, which makes it hard to add a failing test (I presume because of the state tracked by theSanitizedFileclass, which is reused.) There's a lot of moving parts involved here...