Fix file delete being called twice on remove #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a file is removed with something like `.remove_image = true` it's seen as you replacing the file with a new file and still tries to delete the "old file" even though the old file was just deleted. This is mitigated in `CarrierWave::SanitizedFile#delete` by an `if exists?` condition. But it's unnecessary and especially annoying when trying to use a file storage API.
adamcrown
changed the title
| it "should only delete the file once when the file is removed" do | ||
| @event.remove_image = true | ||
| expect_any_instance_of(CarrierWave::SanitizedFile).to receive(:delete).exactly(1).times | ||
| expect(@event.save).to be_true |
There was a problem hiding this comment.
this line should be expect(@event.save).to be true
There was a problem hiding this comment.
RSpec 2.14 is still being used in Carrierwave so be_true works just fine. It's only in Rspec 3 that be true or be_truthy is preferred. You can see that be_true is used throughout the entire file. So I'm just sticking to the convention. I can change it if need be of course but it should probably be changed everywhere at once for consistency.
bensie
added a commit
that referenced
this pull request
Nov 19, 2014
Fix file delete being called twice on remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file is removed with something like
.remove_image = trueit's seen as you replacing the file with a new file and still tries to delete the "old file" even though the old file was just deleted. This is mitigated inCarrierWave::SanitizedFile#deleteby anif exists?condition. But it's unnecessary and especially annoying when trying to use a file storage API.