Don't read file twice in sanitized_file #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can cause excess extra traffic and memory usage, especially with fog. Also remove what seems to be a useless read in the if block and added some initial specs for sanitized_file.
|
I only ran the local tests which were fine, have to setup a test bucket to see what wrong with the specs. |
|
The spec failures are unrelated: |
|
We are having a problem with one gem dependency called fog atm. |
bensie
added a commit
that referenced
this pull request
Nov 19, 2014
…e-read Don't read file twice in sanitized_file
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can cause excess extra traffic and memory usage when using cache! or directly calling sanitized_file, especially with fog. Also removed what seems to be a useless read in the if block.
I added some specs for the normal case, but the case where file.read returns a File is not tested, because I have no idea how to reproduce that situation. It seems to be related to an old issue #814.