[Fix #1571] - Do not write to ActiveModel::Dirty changes when assigning ... #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avgerin0s
force-pushed
the
fix_1571
branch
3 times, most recently
from
2f1d7cb
to
79dc62e
Compare
|
@bensie @plribeiro3000 can you take a look at this please? |
|
I believe this is a safe change. I might be missing something but its a really simple change. 👍 |
|
👍 |
|
Change looks useful, but I think this line is not 'easy readable': |
|
@rusikf I can't think of a better way than |
|
I agree @eavgerinos this is fine as-is. |
|
Will merge it tomorrow after giving it a last crash-test. ^_^ |
|
|
||
| context "and the previous value was an empty string" do | ||
| before do | ||
| @event.image = "" |
There was a problem hiding this comment.
Perhaps you can this guy above to a before block inside the context when empty string is assigned and get a little dry. What do you think?
…ng something blank to a mounter that was originally blank
avgerin0s
added a commit
that referenced
this pull request
May 20, 2015
[Fix #1571] - Do not write to ActiveModel::Dirty changes when assigning ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...something blank to a mounter that was originally blank
This is a WIP. I'm not sure it doesn't break anything yet and want to experiment with it before merging.
Feedback is more than welcome