Change Google's url to the public_url #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensie
added a commit
that referenced
this pull request
Jun 30, 2015
Change Google's url to the public_url
| @@ -353,7 +353,8 @@ def public_url | |||
| end | |||
| end | |||
| when 'Google' | |||
| "https://commondatastorage.googleapis.com/#{@uploader.fog_directory}/#{encoded_path}" | |||
| file = directory.files.get(encoded_path) | |||
| file.nil?? "" : file.public_url | |||
|
this is quite long now, I mean asking fog for the public_url.... I've got plenty of timeouts with this now, occuring withing excon socket, so until I sort all this out I reverted to previous version of this class. |
|
@webattitude If you're having issues with timeouts when requesting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commondatastorageis a deprecated endpoint, the current Request URIs should be used instead, andfog-googleis already up to date.I guess this could be extended to the other providers too.