Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ruby version in CONTRIBUTING.md #1796

Merged
merged 1 commit into from
Dec 15, 2015
Merged

Update Ruby version in CONTRIBUTING.md #1796

merged 1 commit into from
Dec 15, 2015

Conversation

stillwaiting
Copy link
Contributor

I tried to run tests using Ruby 1.8. and failed on bundle install: seems that ruby-filemagic requires at least 1.9.3 version.

Gem::InstallError: ruby-filemagic requires Ruby version >= 1.9.3.
Installing timecop 0.7.1
Installing fission 0.5.0
An error occurred while installing i18n (0.7.0), and Bundler cannot continue.
Make sure that `gem install i18n -v '0.7.0'` succeeds before bundling.
boris@boris-Inspiron-N5040:~/dev/toptal/carrierwave$ gem install i18n -v '0.7.0'
ERROR:  Error installing i18n:
    i18n requires Ruby version >= 1.9.3.
boris@boris-laptop:~/dev/toptal/carrierwave$

thomasfedb
thomasfedb reviewed Dec 14, 2015
View reviewed changes
CONTRIBUTING.md
@@ -29,7 +29,7 @@ You should now be able to run the remote tests:

REMOTE=true bundle exec rake

Please test with the latest Ruby 1.8.x and 1.9.x versions using RVM if possible.
Please test with the latest Ruby 1.9.x version using RVM if possible.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may as well change it to "the latest Ruby 2.2.x version".

@stillwaiting stillwaiting changed the title Remove 1.8 version from CONTRIBUTING.md Update Ruby version in CONTRIBUTING.md Dec 14, 2015
@thomasfedb
Copy link
Contributor

Thanks @stillwaiting, I'll get this merged. ✨

thomasfedb added a commit that referenced this pull request Dec 15, 2015
@thomasfedb
Merge pull request #1796 from stillwaiting/patch-1
ecf57fe 
Update Ruby version specified in CONTRIBUTING.md
@thomasfedb thomasfedb merged commit ecf57fe into carrierwaveuploader:master Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stillwaiting @thomasfedb