-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query parameter support for fog-google #2332
Add query parameter support for fog-google #2332
Conversation
FYI, you'll probably need to update https://github.com/carrierwaveuploader/carrierwave/blob/master/carrierwave.gemspec#L37 to make this work. |
c5a572a
to
78161f2
Compare
@icco Oops, the build is failing here due to https://github.com/fog/fog-google/pull/412/files. |
78161f2
to
b15c9b6
Compare
Build failures are unrelated and related to #2333. |
@mshibuya Could you take a look here? We're shipping this as a monkey patch in GitLab at the moment. |
d7c8c56
to
31e2b92
Compare
May I ask you one more favor, could you make this spec cover fog-google? carrierwave/spec/storage/fog_helper.rb Lines 432 to 437 in 500401c
|
This is to ensure older versions of fog-google don't break.
31e2b92
to
d3d1151
Compare
Sure, good idea. Done. |
Nice work, thanks! |
@mshibuya Would you mind tagging a release now? Thanks! |
Sure, published 1.3.0. |
This requires https://github.com/fog/fog-google/pull/409/files