Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dup with multiple mounters or not cached #2645

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Fix dup with multiple mounters or not cached #2645

merged 1 commit into from
Jan 20, 2023

Commits on Jan 18, 2023

  1. Fix dup with multiple mounters or not cached 

    - Don't call `each` if `@_mounters` is unitialized or nil. It will be
  nil for calls to later mounters, or if not referenced or saved.
- Don't interpolate `column` when it should be a local variable.
- Don't define global functions in specs. Make them local to the block.
- Cover more missing scenarios.
- Fix some rubocop failures.

[Fixes carrierwaveuploader#1962]
    @BrianHawley
    BrianHawley committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    e2af599 View commit details
    Browse the repository at this point in the history