Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for long url filenames (issue 538) #539

Closed
wants to merge 4 commits into from

Conversation

vrinek
Copy link

@vrinek vrinek commented Nov 23, 2011

@vrinek
Copy link
Author

vrinek commented Nov 23, 2011

I just realized something. The maximum filename size does not take into account the version name ("small", "large" etc) in the filename.

@vrinek
Copy link
Author

vrinek commented Nov 23, 2011

it does not look good but it works :)

@bensie
Copy link
Member

bensie commented Nov 23, 2011

Thanks for your work here, but this is far too much of an edge case with too complicated a fix to merge to master. In most cases, a simple validation for the length of the filename is sufficient.

@guich-wo
Copy link

guich-wo commented Feb 6, 2017

got same issue. not such an edge case

@obliviusm
Copy link

me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants