Add link to inline-css #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +21,12 @@ a roots extension for inlining your CSS properties into the style attribute in a | |||
| extensions: [ rootsInlineCss(options) ] | |||
| ``` | |||
|
|
|||
| ### Usage | |||
|
|
|||
| This extension provides a way for you to inline your html with css. By default all of your `html` files will be inlined however you can specify through options which files you want inlined either with a single file or a [glob expression](http://www.globtester.com/). | |||
There was a problem hiding this comment.
i'd rather we reference the actual https://github.com/isaacs/minimatch library, since it will provide the dev with api reference
nimitzshah
force-pushed
the
docs
branch
2 times, most recently
from
ce1f55e
to
a8503b8
Compare
| @@ -10,9 +10,12 @@ a roots extension for inlining your CSS properties into the style attribute in a | |||
|
|
|||
| - make sure you are in your roots project directory | |||
| - `npm install roots-inline-css --save` | |||
| - | |||
| @@ -22,6 +24,10 @@ a roots extension for inlining your CSS properties into the style attribute in a | |||
| extensions: [ rootsInlineCss(options) ] | |||
| ``` | |||
|
|
|||
| This extension provides a way for you to inline your html with css. By default all of your `html` files will be inlined however you can specify through options which files you want inlined either with a single file or a [glob expression]( https://github.com/isaacs/minimatch). | |||
There was a problem hiding this comment.
extra space in markdown anchor src
There was a problem hiding this comment.
This space was to separate the explanation from the code snippet. Should I still remove it?
There was a problem hiding this comment.
extra space not extra newline.
[glob expression]( https://github.com/isaacs/minimatch)should become
[glob expression](https://github.com/isaacs/minimatch)There was a problem hiding this comment.
I noticed that arrays and hashes have a space between the bracket and element. Is this for readability?
[ rootsInlineCss(options) ] as an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used roots-yaml as reference.