Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No addAll in IntSet nor IntCollection #25

Closed
kno10 opened this issue Aug 12, 2021 · 2 comments
Closed

No addAll in IntSet nor IntCollection #25

kno10 opened this issue Aug 12, 2021 · 2 comments
Assignees
Milestone

Comments

@kno10
Copy link

kno10 commented Aug 12, 2021

... but both implementations of IntSet (did not check IntCollection) have addAll().

Likely also applies to other collections.

@dweiss dweiss self-assigned this Aug 13, 2021
@dweiss dweiss added this to the 0.9.1 milestone Aug 13, 2021
@dweiss
Copy link
Member

dweiss commented Aug 13, 2021

Indeed, I see it now. I'll correct the interface, thanks for the tip.

@dweiss
Copy link
Member

dweiss commented Aug 14, 2021

addAll(KTypeContainer<? extends KType> container) is trivial. addAll(KType...) is not because it's a type-unsafe vararg and SafeArgs can't be applied at the interface level (it only applies to final or static methods). After some deliberation I've added just the first version to the interface. I'm not sure what to do about the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants