-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct users who downloaded source to download release #134
Merged
carson-katri
merged 9 commits into
carson-katri:main
from
NullSenseStudio:warn-missing-dependencies
Sep 26, 2022
Merged
Direct users who downloaded source to download release #134
carson-katri
merged 9 commits into
carson-katri:main
from
NullSenseStudio:warn-missing-dependencies
Sep 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carson-katri
requested changes
Sep 25, 2022
carson-katri
requested changes
Sep 26, 2022
Co-authored-by: Carson Katri <Carson.katri@gmail.com>
…nseStudio/dream-textures into warn-missing-dependencies
Co-authored-by: Carson Katri <Carson.katri@gmail.com>
carson-katri
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the extra fixes and repr(e)
changes.
Merged
JasonHoku
pushed a commit
to JasonHoku/dream-textures
that referenced
this pull request
Dec 20, 2022
) * Direct users who downloaded source to download release * modification of ModuleNotFoundError suggestion * misspelling * convert exception to string Co-authored-by: Carson Katri <Carson.katri@gmail.com> * dedicated force show update variable * convert other exception to string Co-authored-by: Carson Katri <Carson.katri@gmail.com> * replace str(exception) with repr(exception) * changes to download messaging Co-authored-by: Carson Katri <Carson.katri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some error handling while loading dependencies within the subprocess and directs users who appear to have downloaded source to instead download from releases.
![blender_ogSY8cKMSl](https://user-images.githubusercontent.com/47096043/192170280-a552ad13-d0bd-46a2-b05f-9cc092b261fc.gif)