Various UI Tweaks #659
Merged
Various UI Tweaks #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NullSenseStudio
commented
May 6, 2023
•
NullSenseStudio
commented
- When there are multiple image editors, generating from an open image source or upscaling will now pick the image from the image editor it was executed from.
- Image editors with image pin activated will no longer be replaced with generated images.
- Cancel generator operator has been slightly changed to better differentiate it from release generator.
- Image texture nodes will now fill the shader editor view better instead of just the bottom right corner.
NullSenseStudio
commented
May 17, 2023
Comment on lines
-83
to
-89
| def step_progress_update(self, context): | ||
| if hasattr(context.area, "regions"): | ||
| for region in context.area.regions: | ||
| if region.type == "UI": | ||
| region.tag_redraw() | ||
| return None | ||
| bpy.types.Scene.dream_textures_progress = bpy.props.IntProperty(name="", default=0, min=0, max=generated_args['steps'], update=step_progress_update) |
There was a problem hiding this comment.
I've found it's more performant to put similar functionality within the step callback. Strangely changing this to an empty function would still allow the UI to redraw. I assume it was redrawing more than necessary for seeing the progress bar. Allows for generating about 15%-20% faster in my experience.
carson-katri
requested changes
May 21, 2023
Co-authored-by: Carson Katri <Carson.katri@gmail.com>
carson-katri
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.