Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support seamless for latest diffusers #725

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

carson-katri
Copy link
Owner

Some changes to LoRACompatibleConv in diffusers broke seamless generation. This patches LoRACompatibleConv.forward to avoid using the functional conv2d (which will ignore the padding mode) and instead use our custom _conv_forward_asymmetric.

Copy link
Collaborator

@NullSenseStudio NullSenseStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It won't properly support LoRA with seamless axes as it is, but it can be revised if LoRA integration is ever added in the future.

@carson-katri carson-katri merged commit 4259389 into main Nov 6, 2023
@carson-katri carson-katri deleted the seamless-lora-fix branch November 6, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants