Clean up Python code #4
Merged
+7
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy to have you clean this up. Is it ok with you if I squash and merge the 3 commits into one? |
|
Fine with me. Unfortunately there is a conflict now. |
|
Probably because I have already pulled in the other PR |
- Remove sublime_lib usage. - Sort imports and some whitespace stuff. - Don't set default_dir. - begin_edit and end_edit have been removed in ST3.
FichteFoll
force-pushed
the
pr/no-sublime-lib
branch
from
203a3a3
to
dfe5612
Compare
|
There we go. |
|
Merged! Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been deprecated by PackageDev long ago and the functionality
used is trivial. In fact, it's not even importable on ST3 anymore.
Also sort imports and some whitespace stuff.