Skip to content

Commit

Permalink
Update Snapshots for line height (WordPress#60041)
Browse files Browse the repository at this point in the history
* Update snapshots to fix JS tests and match changes from WordPress#60028
* Add changelog entry


---------

Co-authored-by: scruffian <scruffian@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
  • Loading branch information
5 people authored and carstingaxion committed Mar 27, 2024
1 parent 67a395d commit 7864e2d
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 23 deletions.
8 changes: 6 additions & 2 deletions packages/components/CHANGELOG.md
@@ -1,12 +1,14 @@
<!-- Learn how to maintain this file at https://github.com/WordPress/gutenberg/tree/HEAD/packages#maintaining-changelogs. -->

## Unreleased
- `Dropdown` : Add styling support for `MenuGroup` ([#59723](https://github.com/WordPress/gutenberg/pull/59723)).
- `Placeholder` : Allow overflow but only when placeholder is selected, to fix a layout shift. `MenuGroup` ([#59857](https://github.com/WordPress/gutenberg/pull/59857)).

- `Dropdown` : Add styling support for `MenuGroup` ([#59723](https://github.com/WordPress/gutenberg/pull/59723)).
- `Placeholder` : Allow overflow but only when placeholder is selected, to fix a layout shift. ([#59857](https://github.com/WordPress/gutenberg/pull/59857)).

### Enhancements

- `TextControl`: Add typings for `date`, `time` and `datetime-local` ([#59666](https://github.com/WordPress/gutenberg/pull/59666)).
- `Text`, `Heading`, `ItemGroup` : Update the line height from 1.2 to 1.4 ([#60041](https://github.com/WordPress/gutenberg/pull/60041)).

### Deprecation

Expand All @@ -17,12 +19,14 @@
- `Button`: Keep deprecated props in type definitions ([#59913](https://github.com/WordPress/gutenberg/pull/59913)).

### Bug Fix

- `PaletteEdit`: Fix number incrementing of default names for new colors added in non-en-US locales ([#52212](https://github.com/WordPress/gutenberg/pull/52212)).
- `DateTimePicker`: Change day button size back from 32px to 28px ([#59990](https://github.com/WordPress/gutenberg/pull/59990)).

## 27.1.0 (2024-03-06)

### Bug Fix

- `InputControl`: Fix sample code on InputControl docs [#59517](https://github.com/WordPress/gutenberg/pull/59517)
- `Tooltip`: Explicitly set system font to avoid CSS bleed ([#59307](https://github.com/WordPress/gutenberg/pull/59307)).
- `HStack`, `VStack`: Stop passing invalid props to underlying element ([#59416](https://github.com/WordPress/gutenberg/pull/59416)).
Expand Down
Expand Up @@ -59,7 +59,7 @@ exports[`DimensionControl rendering renders with custom sizes 1`] = `
.emotion-11 {
color: #1e1e1e;
line-height: 1.2;
line-height: 1.4;
margin: 0;
font-size: calc((13 / 13) * 13px);
font-weight: normal;
Expand Down Expand Up @@ -330,7 +330,7 @@ exports[`DimensionControl rendering renders with defaults 1`] = `
.emotion-11 {
color: #1e1e1e;
line-height: 1.2;
line-height: 1.4;
margin: 0;
font-size: calc((13 / 13) * 13px);
font-weight: normal;
Expand Down Expand Up @@ -611,7 +611,7 @@ exports[`DimensionControl rendering renders with icon and custom icon label 1`]
.emotion-11 {
color: #1e1e1e;
line-height: 1.2;
line-height: 1.4;
margin: 0;
font-size: calc((13 / 13) * 13px);
font-weight: normal;
Expand Down Expand Up @@ -904,7 +904,7 @@ exports[`DimensionControl rendering renders with icon and default icon label 1`]
.emotion-11 {
color: #1e1e1e;
line-height: 1.2;
line-height: 1.4;
margin: 0;
font-size: calc((13 / 13) * 13px);
font-weight: normal;
Expand Down
Expand Up @@ -3,7 +3,7 @@
exports[`props should render correctly 1`] = `
.emotion-0 {
color: #1e1e1e;
line-height: 1.2;
line-height: 1.4;
margin: 0;
color: #1e1e1e;
font-size: calc(1.95 * 13px);
Expand Down Expand Up @@ -32,7 +32,7 @@ Snapshot Diff:
- "font-size": "calc(1.25 * 13px)",
+ "font-size": "calc(1.95 * 13px)",
"font-weight": "600",
"line-height": "1.2",
"line-height": "1.4",
"margin": "0",
},
]
Expand All @@ -50,7 +50,7 @@ Snapshot Diff:
- "font-size": "calc(1.25 * 13px)",
+ "font-size": "calc(1.95 * 13px)",
"font-weight": "600",
"line-height": "1.2",
"line-height": "1.4",
"margin": "0",
},
]
Expand Down
22 changes: 11 additions & 11 deletions packages/components/src/item-group/test/__snapshots__/index.js.snap
Expand Up @@ -11,8 +11,8 @@ Snapshot Diff:
role="listitem"
>
<div
- class="components-item css-ufjlmj-View-medium-item-spacedAround e19lxcc00"
+ class="components-item css-17haj95-View-large-item-spacedAround e19lxcc00"
- class="components-item css-1n28wmo-View-medium-item-spacedAround e19lxcc00"
+ class="components-item css-gg7ygh-View-large-item-spacedAround e19lxcc00"
data-wp-c16t="true"
data-wp-component="Item"
>
Expand All @@ -24,8 +24,8 @@ Snapshot Diff:
role="listitem"
>
<div
- class="components-item css-ufjlmj-View-medium-item-spacedAround e19lxcc00"
+ class="components-item css-17haj95-View-large-item-spacedAround e19lxcc00"
- class="components-item css-1n28wmo-View-medium-item-spacedAround e19lxcc00"
+ class="components-item css-gg7ygh-View-large-item-spacedAround e19lxcc00"
data-wp-c16t="true"
data-wp-component="Item"
>
Expand All @@ -44,8 +44,8 @@ Snapshot Diff:
role="listitem"
>
<div
- class="components-item css-cl593w-View-medium-item e19lxcc00"
+ class="components-item css-1yvqxd-View-large-item e19lxcc00"
- class="components-item css-1lf4kzd-View-medium-item e19lxcc00"
+ class="components-item css-1vv4aem-View-large-item e19lxcc00"
data-wp-c16t="true"
data-wp-component="Item"
>
Expand Down Expand Up @@ -74,7 +74,7 @@ exports[`ItemGroup ItemGroup component should render correctly 1`] = `
}
.emotion-3 {
padding: calc((36px - calc(13px * 1.2) - 2px) / 2) 12px;
padding: calc((36px - calc(13px * 1.4) - 2px) / 2) 12px;
box-sizing: border-box;
width: 100%;
display: block;
Expand Down Expand Up @@ -125,8 +125,8 @@ Snapshot Diff:
role="listitem"
>
<div
- class="components-item css-ufjlmj-View-medium-item-spacedAround e19lxcc00"
+ class="components-item css-cl593w-View-medium-item e19lxcc00"
- class="components-item css-1n28wmo-View-medium-item-spacedAround e19lxcc00"
+ class="components-item css-1lf4kzd-View-medium-item e19lxcc00"
data-wp-c16t="true"
data-wp-component="Item"
>
Expand All @@ -153,8 +153,8 @@ Snapshot Diff:
role="listitem"
>
<div
- class="components-item css-ufjlmj-View-medium-item-spacedAround e19lxcc00"
+ class="components-item css-cl593w-View-medium-item e19lxcc00"
- class="components-item css-1n28wmo-View-medium-item-spacedAround e19lxcc00"
+ class="components-item css-1lf4kzd-View-medium-item e19lxcc00"
data-wp-c16t="true"
data-wp-component="Item"
>
Expand Down
Expand Up @@ -9,7 +9,7 @@ Snapshot Diff:
"color": "#1e1e1e",
"font-size": "calc((13 / 13) * 13px)",
"font-weight": "normal",
"line-height": "1.2",
"line-height": "1.4",
"margin": "0",
+ "text-align": "center",
},
Expand All @@ -19,7 +19,7 @@ Snapshot Diff:
exports[`Text should render highlighted words with highlightCaseSensitive 1`] = `
.emotion-0 {
color: #1e1e1e;
line-height: 1.2;
line-height: 1.4;
margin: 0;
font-size: calc((13 / 13) * 13px);
font-weight: normal;
Expand Down Expand Up @@ -50,7 +50,7 @@ exports[`Text should render highlighted words with highlightCaseSensitive 1`] =
exports[`Text snapshot tests should render correctly 1`] = `
.emotion-0 {
color: #1e1e1e;
line-height: 1.2;
line-height: 1.4;
margin: 0;
font-size: calc((13 / 13) * 13px);
font-weight: normal;
Expand Down

0 comments on commit 7864e2d

Please sign in to comment.