Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cartalyst/stripe v1.0.0 requires guzzlehttp/guzzle ~5.2 #11

Closed
wkolcz opened this issue Nov 27, 2015 · 13 comments
Closed

cartalyst/stripe v1.0.0 requires guzzlehttp/guzzle ~5.2 #11

wkolcz opened this issue Nov 27, 2015 · 13 comments

Comments

@wkolcz
Copy link

wkolcz commented Nov 27, 2015

I have guzzlehttp/guzzle installed on my application (6.1,as a dependency of another package) and cartalyst/stripe-laravel will not install. I need cartalyst/stripe v1.0.0 installed which is asking for guzzlehttp/guzzle ~5.2

Any thoughts on how to get the 2 to play nice and allow me to install on my Laravel 5.1 application?

@GrahamCampbell
Copy link
Contributor

Laravel 5.1 works fine with Guzzle 5. I personally ensured that it did.

@GrahamCampbell
Copy link
Contributor

Note that Laravel 5.2 does not support guzzle 5. I removed the BC layer. Though, if you're not using any parts of Laravel that rely on guzzle, you can of course install any version. Laravel only suggests the guzzle version and does not enforce it.

@GrahamCampbell
Copy link
Contributor

In terms of getting this library updated to Guzzle 6, I raised this issue a while back but my issue was closed :(

See cartalyst/stripe#31.

@wkolcz
Copy link
Author

wkolcz commented Nov 27, 2015

I need 6 for another library so I guess the 2 are not compatible then with my application since it will not install with 6

@GrahamCampbell
Copy link
Contributor

What library is that. Could it be easily modified to support guzzle 5 too?

@wkolcz
Copy link
Author

wkolcz commented Nov 27, 2015

neoxygen/neoclient. The application I am building is with Neo4j

@GrahamCampbell
Copy link
Contributor

I've started cartalyst/stripe#44.

@GrahamCampbell
Copy link
Contributor

Version 2.x of neoxygen/neoclient support guzzle 5 btw.

@GrahamCampbell
Copy link
Contributor

@wkolcz
Copy link
Author

wkolcz commented Nov 27, 2015

I'm sorry, I am not using an outdated library for my application to gain another library. I don't think versioning down one library for another is a solution.

@GrahamCampbell
Copy link
Contributor

That's fine. I'm just offering a solution. It's basically that, or nothing at the moment.

@GrahamCampbell
Copy link
Contributor

If you'd like to take over on my guzzle 6 upgrade PR, that's fine. Just let me know. I'm short on time so am unlikely to finish it quickly.

@wkolcz
Copy link
Author

wkolcz commented Nov 27, 2015

Thanks for the suggestion. What do you need to a guzzle 6 upgrade PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants