fix: Look for array and object patterns.

cartant · Jan 12, 2022 · f0f0cf3 · f0f0cf3
1 parent 8088208
commit f0f0cf3
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 7 deletions.
diff --git a/source/rules/no-ignored-takewhile-value.ts b/source/rules/no-ignored-takewhile-value.ts
@@ -4,7 +4,12 @@
  */
 
 import { TSESTree as es } from "@typescript-eslint/experimental-utils";
-import { isIdentifier, isImport } from "eslint-etc";
+import {
+  isArrayPattern,
+  isIdentifier,
+  isImport,
+  isObjectPattern,
+} from "eslint-etc";
 import { ruleCreator } from "../utils";
 
 const rule = ruleCreator({
@@ -33,11 +38,17 @@ const rule = ruleCreator({
       }
       let ignored = true;
       const [param] = expression.params;
-      if (param && isIdentifier(param)) {
-        const variable = scope.variables.find(
-          ({ name }) => name === param.name
-        );
-        if (variable && variable.references.length > 0) {
+      if (param) {
+        if (isIdentifier(param)) {
+          const variable = scope.variables.find(
+            ({ name }) => name === param.name
+          );
+          if (variable && variable.references.length > 0) {
+            ignored = false;
+          }
+        } else if (isArrayPattern(param)) {
+          ignored = false;
+        } else if (isObjectPattern(param)) {
           ignored = false;
         }
       }

diff --git a/tests/rules/no-ignored-takewhile-value.ts b/tests/rules/no-ignored-takewhile-value.ts
@@ -70,7 +70,20 @@ ruleTester({ types: true }).run("no-ignored-takewhile-value", rule, {
       class Something {
         constructor(private _source: Observable<{ name: string }>) {
           _source.pipe(
-            takeWhile(({ name }) => { return name; })
+            takeWhile(({ name }) => name)
+          ).subscribe();
+        }
+      };
+    `,
+    stripIndent`
+      // Array destructuring
+      import { Observable } from "rxjs";
+      import { takeWhile } from "rxjs/operators";
+
+      class Something {
+        constructor(private _source: Observable<string[]>) {
+          _source.pipe(
+            takeWhile(([name]) => name)
           ).subscribe();
         }
       };