Fix eslint-etc issue where hasTypeAnnotation function does not evaluate 'typeAnnotation' properly in call cases. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
recommendedconfig crashes eslint due to an issue with undefined property detection/testing.The intended behavior of hasOwnProperty only seems to work when a property is explicitly set as undefined. When values are implicitly set. This behavior is consistent with
Object.hasOwn,object.hasOwnPropertyand'property' in object.Here is a TS Playground demonstrating this behavior.
Only
if(obj.typeAnnotation)and!!obj.typeAnnotationboth consistently return false.The easiest way to check for a typeAnnotation at this branch is to simply check for truthiness with
if(param.typeAnnotation), which I have implemented in this PR.Fixes #122