Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Having an option to keep or replace generated moment or pv images when a new request is made (frontend) #1951

Closed
kswang1029 opened this issue Aug 4, 2022 · 3 comments · Fixed by #2007
Closed

Having an option to keep or replace generated moment or pv images when a new request is made (frontend) #1951

kswang1029 opened this issue Aug 4, 2022 · 3 comments · Fixed by #2007
Assignees
@crocka
Labels
enhancement New feature or request requiring backend For issues or pull requests that require work in both frontend and backend

Comments

@kswang1029
Copy link
Collaborator

kswang1029 commented Aug 4, 2022 •
edited

user feedback from v3 beta test

With v3 release, when a new request made in the pv generator or moment generator, generated images from the previous request will be removed. Users would like to have an option to keep or replace the pv or moment images.

The companion backend issue is CARTAvis/carta-backend#1176
@kswang1029 kswang1029 added the enhancement New feature or request label Aug 4, 2022
@kswang1029 kswang1029 mentioned this issue Aug 4, 2022
Closed
@kswang1029 kswang1029 added the requiring backend For issues or pull requests that require work in both frontend and backend label Aug 4, 2022
@crocka crocka linked a pull request Sep 28, 2022 that will close this issue
carli/1950_1951_1952_pv_x_y_axis_setting #2007
Merged
8 tasks
@pford
Copy link
Collaborator

pford commented Oct 12, 2022

Does PR #2007 for this issue include keep/replace moment images? In the backend, I separated the moment feature in a new issue #1202 and opened draft PR #1203.

@pford
Copy link
Collaborator

pford commented Nov 22, 2022

@crocka was this done for Moment images too? If not, we need to create a new issue for it. I opened PR [#1203](CARTAvis/carta-backend#1203 for issue 1202) for the backend part.

@crocka
Copy link
Contributor

crocka commented Nov 22, 2022

@crocka was this done for Moment images too? If not, we need to create a new issue for it. I opened PR [#1203](CARTAvis/carta-backend#1203 for issue 1202) for the backend part.

No, it's not done for moment images.

@pford pford mentioned this issue Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crocka crocka

Labels
enhancement New feature or request requiring backend For issues or pull requests that require work in both frontend and backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

carli/1950_1951_1952_pv_x_y_axis_setting CARTAvis/carta-frontend
3 participants
@pford @kswang1029 @crocka