Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on macos with homebrew #146

Closed
wants to merge 4 commits into from
Closed

Build on macos with homebrew #146

wants to merge 4 commits into from

Conversation

tuler
Copy link
Member

@tuler tuler commented Oct 14, 2023

CI build using homebrew on macOS.

closes #145

@tuler tuler requested a review from vfusco October 14, 2023 20:47
@tuler
Copy link
Member Author

tuler commented Oct 15, 2023

Error linking absl::lts_20230802
Maybe related to protocolbuffers/protobuf#12292

@tuler
Copy link
Member Author

tuler commented Oct 15, 2023

This way of deciding whether it's homebrew does not work well.

Homebrew when installed in Apple Silicon even uses a different directory, /opt/homebrew instead of /usr/local
https://docs.brew.sh/FAQ#why-is-the-default-installation-prefix-opthomebrew-on-apple-silicon
So none of the includes and libs work on Apple Silicon. Maybe we should use brew --prefix

@vfusco vfusco force-pushed the feature/macos-ci-build branch 4 times, most recently from 46673d0 to 6b2c780 Compare October 24, 2023 21:54
@vfusco
Copy link
Contributor

vfusco commented Oct 26, 2023

PR #149 fixed this. Closing.

@vfusco vfusco closed this Oct 26, 2023
@vfusco vfusco deleted the feature/macos-ci-build branch October 26, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homebrew build instructions are not working
2 participants