Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there an up-to-date gRPC documentation? #1430

Closed
abylikhsanov opened this issue Dec 15, 2019 · 7 comments
Closed

Is there an up-to-date gRPC documentation? #1430

abylikhsanov opened this issue Dec 15, 2019 · 7 comments
Labels

Comments

@abylikhsanov
Copy link

Hi,

I came across this video:
https://vimeo.com/293260413

And I decided to try this method as I am using an ICP localization technique which relies on the static objects. So after some research I found this link:
https://github.com/googlecartographer/rfcs/blob/master/text/0002-cloud-based-mapping-1.md#cartographer_grpc

And I guess it is outdated as the name of the gRPC nodes are different in the cartographer source folder. Also the official documentation includes the gRPC integration but says nothing about it.

Is there some updated documentation about it?

@shreyasgokhale
Copy link

shreyasgokhale commented Jan 11, 2020

Hi,

Have a look at #1300 (comment) from issue #1300 . But apart from that, there is not much documentation as per my knowledge.

You can use https://github.com/shreyasgokhale/cartographer-grpc to quickly test gRPC with cartographer.

@abylikhsanov
Copy link
Author

Hi, thanks, I have already figured out. I can see that your docker compose file opens up the ports. Did you have a problem of accessing those ports of the agent is running outside the server's subnet?

@shreyasgokhale
Copy link

I think you will have to tweak the IP values of files in postinstall folder. But as it uses docker's host networking, your agent should be able to connect to this server, (at least if it is in the same local network). If you want to connect from outside the network, you can try to use something like this.

Also, I followed this post to create the architecture.

Also now I look at it, I haven't updated cartographer-grpc repo in a while. I'll push my latest changes soon, with working server, agent and docs.

@carola173
Copy link

carola173 commented Jun 30, 2020

@shreyasgokhale I am trying to replicate the same architecture given in the reference link. I am able to create the cartographer server node which is running properly. But when the client is create, after few seconds the client-server communication breaks with the following message. It would be great if you can help me with this error if possible.
The client side output:
Screenshot from 2020-06-30 16-58-08

The server side output:
Screenshot from 2020-06-30 16-58-19

I am running on two different Ubuntu 18.04 system (ROS Melodic) that are connected to same network in which one i am running the server and another on i am running the client. Also I am using the master repo for cartographer, cartographer_ros, asyn_grpc,grpc++(1.29) and protoc with 3 verison.

Many thanks !!!

@shreyasgokhale
Copy link

Hi @carola173, it is hard to debug just by looking at the error. What launch files / launch commands are you using?

@carola173
Copy link

@shreyasgokhale I am using the following launch commands:
On server side the launch looks like :
Screenshot from 2020-07-01 14-31-43

and configuration setup as :
Screenshot from 2020-07-01 14-32-32

Agent side I am launching following stuff:

Launch file :
Screenshot from 2020-07-01 14-42-28 (1)

Configuration file :
Screenshot from 2020-07-01 14-50-58 (1)

The cloud_slam.lua and the my_robot.lua is similar to backpack_2d.lua file.

I hope these are proper launch file and configuration. Thanks a lot for helping.

@MichaelGrupp
Copy link
Contributor

MichaelGrupp commented Oct 14, 2020

My older answere here is still mostly valid: #1300 (comment)

The project is being maintained again, but I can't tell you if, when or how an extended public documentation of the cloud features will happen at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants