Backport Qt5 patch for QSetting null bytes issue. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've currently been compiling with the same patches for the past 10 minutes. If it worked I would've made a PR. Looks like you got me beat! I'll let you know if it goes well! |
|
Yes, I can confirm this fixes the problem. +1 |
|
@winneon Great! Thanks for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1 by including mumble-voip/mumble-developers-qt@38ca587 as a patch file to be applied to the
qtformula.@winneon @alby128 Is there any chance someone who uses Syncplay could test and see if it works correctly with this patch applied?