Adds progress bar for image push #421
Conversation
shaheerkootteeri
force-pushed
the
Issue440-progress-imgpkgpush
branch
from
4129005
to
366e1ae
Compare
shaheerkootteeri
force-pushed
the
Issue440-progress-imgpkgpush
branch
from
2e32e94
to
e7166ad
Compare
shaheerkootteeri
force-pushed
the
Issue440-progress-imgpkgpush
branch
from
433cfcc
to
41f257a
Compare
shaheerkootteeri
force-pushed
the
Issue440-progress-imgpkgpush
branch
from
7bf316a
to
bbcc0d1
Compare
| // Start the display of the Progress Bar | ||
| func (l *ProgressBarLogger) Start(ctx context.Context, progressChan <-chan regv1.Update) { | ||
| ctx, cancelFunc := context.WithCancel(ctx) | ||
| l.cancelFunc = cancelFunc |
There was a problem hiding this comment.
im assuming we are not using ProgressBarLogger concurrently?
There was a problem hiding this comment.
No we are not using
pkg/imgpkg/registry/with_progress.go
Outdated
| @@ -4,6 +4,8 @@ | |||
| package registry | |||
|
|
|||
| import ( | |||
| context "context" | |||
There was a problem hiding this comment.
nit: redundant aliasing
There was a problem hiding this comment.
I will remove the alias
There was a problem hiding this comment.
Addressed in the latest commit.
pkg/imgpkg/plainimage/contents.go
Outdated
| excludedPaths []string | ||
| paths []string | ||
| excludedPaths []string | ||
| displayProgress bool |
There was a problem hiding this comment.
we wouldn't need the displayProgress flag as it is not used anymore, however we would need the paths and excluded paths. I will remove the displayProgress flag
There was a problem hiding this comment.
Removed the displayProgress as part of the latest commit
| if l.cancelFunc != nil { | ||
| l.cancelFunc() | ||
| } | ||
| if l.ui != nil && l.finalMessage != "" { |
There was a problem hiding this comment.
do we need to check on l.ui != nil here?
There was a problem hiding this comment.
In the case of a NOOP progress logger as part of the bundle push , we are not passing any UI as there will not be any progress bar displaying. However we could have the same accepting ui as well and we would need the nil check to decide if possible to display final message.
This PR resolves Issue #420 to have progress bar displayed for Image push.