fix linter errors

carvel-dev · Jul 26, 2022 · 1995b8c · 1995b8c
1 parent cb85b43
commit 1995b8c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/pkg/apis/kappctrl/v1alpha1/types.go b/pkg/apis/kappctrl/v1alpha1/types.go
@@ -166,11 +166,13 @@ type AppStatusDeploy struct {
 	KappDeployStatus KappDeployStatus `json:"kapp,omitempty"`
 }
 
+// KappDeployStatus todo
 // +protobuf=false
 type KappDeployStatus struct {
 	AssociatedResources AssociatedResources `json:"associatedResources,omitempty"`
 }
 
+// AssociatedResources todo
 // +protobuf=false
 type AssociatedResources struct {
 	Label      string             `json:"label,omitempty"`

diff --git a/pkg/app/app_deploy.go b/pkg/app/app_deploy.go
@@ -123,7 +123,8 @@ func (a *App) inspect() exec.CmdRunResult {
 	return result
 }
 
-type AppMeta struct {
+// Meta todo
+type Meta struct {
 	LabelKey   string `yaml:"labelKey"`
 	LabelValue string `yaml:"labelValue"`
 	LastChange struct {
@@ -135,7 +136,8 @@ type AppMeta struct {
 	} `yaml:"usedGKs"`
 }
 
-func (a *App) GetMetadata() (AppMeta, error) {
+// GetMetadata todo
+func (a *App) GetMetadata() (Meta, error) {
 
 	for _, dep := range a.app.Spec.Deploy {
 		switch {
@@ -145,28 +147,28 @@ func (a *App) GetMetadata() (AppMeta, error) {
 
 			kapp, err := a.newKapp(*dep.Kapp, cancelCh)
 			if err != nil {
-				return AppMeta{}, err
+				return Meta{}, err
 			}
 
 			cm, err := kapp.InternalAppConfigMap()
 			if err != nil {
-				return AppMeta{}, err
+				return Meta{}, err
 			}
 
-			var appMetadata AppMeta
+			var appMetadata Meta
 			err = yaml.Unmarshal([]byte(cm.Data["spec"]), &appMetadata)
 			if err != nil {
-				return AppMeta{}, err
+				return Meta{}, err
 			}
 
 			return appMetadata, err
 		default:
-			return AppMeta{}, fmt.Errorf("Unsupported way to get config map")
+			return Meta{}, fmt.Errorf("Unsupported way to get config map")
 		}
 
 	}
 
-	return AppMeta{}, fmt.Errorf("Unsupported way to get config map")
+	return Meta{}, fmt.Errorf("Unsupported way to get config map")
 }
 
 func (a *App) newKapp(kapp v1alpha1.AppDeployKapp, cancelCh chan struct{}) (*ctldep.Kapp, error) {

diff --git a/pkg/deploy/kapp.go b/pkg/deploy/kapp.go
@@ -131,6 +131,7 @@ func (a *Kapp) Inspect() exec.CmdRunResult {
 	return result
 }
 
+// InternalAppConfigMap todo
 func (a *Kapp) InternalAppConfigMap() (*corev1.ConfigMap, error) {
 	var configMap *corev1.ConfigMap