Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surface in App CR status set of namespaces used for the deployment #535

Closed
cppforlife opened this issue Mar 2, 2022 · 5 comments · Fixed by #799
Closed

surface in App CR status set of namespaces used for the deployment #535

cppforlife opened this issue Mar 2, 2022 · 5 comments · Fixed by #799
Assignees
Labels
enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.

Comments

@cppforlife
Copy link
Contributor

cppforlife commented Mar 2, 2022

Describe the problem/challenge you have
[A description of the current challenge that you are experiencing.]

it's useful for users of App CR and PackageInstall CR to know which namespaces hold deployed resources. internally kapp ls presents a list of used namespaces, however such information would only be accessible to direct kapp CLI users. it would be nice to somehow surface this info in App CR status, e.g.

status:
  deploy:
     usedNamespaces:
     - "" # empty to represent cluster-scope
     - knative-serving
     - knative-eventing

Describe the solution you'd like
[A clear and concise description of what you want to happen. If applicable a visual representation of the UX.]

Anything else you would like to add:
[Additional information that will assist in solving the issue.]

this problem might be also generally related to letting users identify what are resources that are part of this app/packageinstall.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@cppforlife cppforlife added enhancement This issue is a feature request carvel-triage This issue has not yet been reviewed for validity labels Mar 2, 2022
@joe-kimmel-vmw
Copy link
Contributor

@cppforlife in discussion with @benmoss @neil-hickey we're wondering if it's worth a discussion re. solving the full case of "letting users identify what resources are part of this app/pkgi" vs the special case of just namespaces?

@neil-hickey neil-hickey removed the carvel-triage This issue has not yet been reviewed for validity label Mar 2, 2022
@cppforlife
Copy link
Contributor Author

possibly. though, i could see how identifying all resources might be an expensive operation vs identifying namespaces at the time of the deploy might be cheap. would love to hear ideas on more generic api though.

@benmoss
Copy link
Contributor

benmoss commented Mar 2, 2022

We have the resources at deploy time, right? I think this is a good example of a case where if we were using a kapp SDK this would be easy, but instead all that data is lost inside the CLI.

status:
  deploy:
     resources:
     - {apiVersion: "v1", kind: "Namespace", name: "knative-serving"}
     - {apiVersion: "v1", kind: "ServiceAccount", name: "knative-serving", namespace: "knative-serving"}

@cppforlife
Copy link
Contributor Author

  • i have a concern about size of the App CR since this list could be 100s of resources long
  • if we find this feature useful, it's more than likely other uses of kapp would benefit as well (ie having a mechanism to get this info from kapp CLI should be a reasonable ask)

@joe-kimmel-vmw
Copy link
Contributor

a couple of notes from a followup discussion:

  • providing namespace to TMC users can be thought of like "tell the users what directory you're storing files in" metaphor from a local install
  • we should ensure we understand what resources users are interested in (would kubectl get all provide them?) and what the real goal (the "... So That ...") of the users who requested this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants