Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface namespace and GK resources in AppCR status #799

Merged
merged 1 commit into from Aug 11, 2022
Merged

Surface namespace and GK resources in AppCR status #799

merged 1 commit into from Aug 11, 2022

Conversation

DennisDenuto
Copy link
Contributor

@DennisDenuto DennisDenuto commented Jul 26, 2022 •
edited by neil-hickey

TODO:

  • do code TODO's
  • remove any hardcoding left over
  • fix up commits
  • fix linter errors / code styling errors
  • remove kapp linux binary change from PR

What this PR does / why we need it:

  • Allow the ability to discover what k8s resources belong to an App CR

Which issue(s) this PR fixes:

Fixes #535

Does this PR introduce a user-facing change?

- namespaces and GK's are set on AppCR.KappDeployStatus.AssociatedResources

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

@DennisDenuto DennisDenuto changed the title Surface resources Surface namespace and GK resources in AppCR status Jul 26, 2022
@DennisDenuto DennisDenuto mentioned this pull request Jul 27, 2022
Merged
7 tasks
@100mik
Copy link
Contributor

100mik commented Jul 27, 2022

Oooh! This will really help us put together something like kctrl app inspect -a app-name which lets users inspect resources created by kapp for an app

@DennisDenuto DennisDenuto force-pushed the surface-resources branch 11 times, most recently from 4d484e1 to fd08e99 Compare August 3, 2022 22:26
@DennisDenuto DennisDenuto marked this pull request as ready for review August 3, 2022 22:55
cppforlife
cppforlife reviewed Aug 4, 2022
View reviewed changes
pkg/deploy/kapp.go Outdated Show resolved Hide resolved
test/e2e/kappcontroller/app_status_test.go Outdated Show resolved Hide resolved
test/e2e/kappcontroller/app_status_test.go Outdated Show resolved Hide resolved
test/e2e/kappcontroller/app_status_test.go Outdated Show resolved Hide resolved
test/e2e/kappcontroller/app_status_test.go Outdated Show resolved Hide resolved
pkg/app/app_deploy.go Outdated Show resolved Hide resolved
pkg/app/app_deploy.go Outdated Show resolved Hide resolved
test/e2e/kappcontroller/app_status_test.go Outdated Show resolved Hide resolved
pkg/deploy/kapp.go Outdated Show resolved Hide resolved
pkg/app/app_reconcile.go Outdated Show resolved Hide resolved
neil-hickey
neil-hickey reviewed Aug 4, 2022
View reviewed changes
pkg/app/app_reconcile.go Outdated Show resolved Hide resolved
pkg/deploy/kapp.go Outdated Show resolved Hide resolved
pkg/deploy/kapp.go Show resolved Hide resolved
pkg/app/app_reconcile.go Outdated Show resolved Hide resolved
pkg/app/app_deploy.go Outdated Show resolved Hide resolved
@DennisDenuto DennisDenuto force-pushed the surface-resources branch 4 times, most recently from 581e36e to 086a311 Compare August 4, 2022 21:57
cppforlife
cppforlife reviewed Aug 8, 2022
View reviewed changes
pkg/deploy/kapp.go Outdated Show resolved Hide resolved
pkg/deploy/kapp.go Show resolved Hide resolved
test/e2e/kappcontroller/app_status_test.go Outdated Show resolved Hide resolved
test/e2e/kappcontroller/app_status_test.go Outdated Show resolved Hide resolved
pkg/apis/kappctrl/v1alpha1/types.go Outdated Show resolved Hide resolved
@DennisDenuto DennisDenuto force-pushed the surface-resources branch 4 times, most recently from 3df870b to 8df0d87 Compare August 8, 2022 20:14
cppforlife
cppforlife reviewed Aug 9, 2022
View reviewed changes
pkg/app/app_deploy.go Outdated Show resolved Hide resolved
pkg/deploy/kapp.go Outdated Show resolved Hide resolved
test/e2e/kappcontroller/app_status_test.go Show resolved Hide resolved
@DennisDenuto @neil-hickey
feat: Surface App resources associated to a deploy
da9a759 
- Uses kapp metadata file to list on the AppCR status the app label, namespaces and GK's

Signed-off-by: Neil Hickey <nhickey@vmware.com>
@cppforlife cppforlife merged commit 04c7e27 into develop Aug 11, 2022
@cppforlife cppforlife deleted the surface-resources branch August 11, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppforlife cppforlife cppforlife left review comments

@neil-hickey neil-hickey neil-hickey left review comments

@praveenrewar praveenrewar praveenrewar left review comments

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

surface in App CR status set of namespaces used for the deployment
6 participants
@DennisDenuto @100mik @cppforlife @neil-hickey @praveenrewar @vmwclabot