feat: Configurable default package install sync period #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imusmanmalik
force-pushed
the
feat/defaultPackageInstallSyncPeriod
branch
from
4dfde9a
to
6a5feb3
Compare
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
imusmanmalik
force-pushed
the
feat/defaultPackageInstallSyncPeriod
branch
from
6a5feb3
to
8776976
Compare
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
imusmanmalik
force-pushed
the
feat/defaultPackageInstallSyncPeriod
branch
from
bd4596f
to
729f8bc
Compare
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
imusmanmalik
force-pushed
the
feat/defaultPackageInstallSyncPeriod
branch
from
7c939f9
to
62b5196
Compare
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
imusmanmalik
changed the title
praveenrewar
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Just a few minor nits, looks good to me otherwise. Thank you so much for working on it @imusmanmalik 🚀
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
This reverts commit 4fa8ccc. Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
|
Cool, Thx 👍 |
github-actions
bot
added
the
carvel-triage
praveenrewar
removed
the
carvel-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
It could resolve partially the issue.
Does this PR introduce a user-facing change?
Not directly but user can now have a configurable global default
syncPeriodvalue forAppcreated usingPackageInstall.Previously the value was
hardcodedto10m, it could be modified by specifyingsyncPeriodas part ofPackageInstallmanifest, However having a default global value could be useful for some use-cases where specifying asyncPeriodis tedious to everyPackageInstallmanifest.The default
10mis still respected after having a discussion with the community / maintainers on Slack: https://kubernetes.slack.com/archives/CH8KCCKA5/p1686321873099489Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.:
Docs PR: carvel-dev/carvel#658