Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for exactly one package and one metadata resource #1295

Merged

Conversation

andrew-su
Copy link
Contributor

What this PR does / why we need it:

Having the correct conditional here prevents an index out of range error further down the code

Which issue(s) this PR fixes:

Fixes #1294

Signed-off-by: Andrew Su <suan@vmware.com>
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the fix @andrew-su 🚀
Would you be open to adding a test for this? (A separate PR later on is fine as well)

cli/pkg/kctrl/cmd/package/release/release.go Show resolved Hide resolved
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@praveenrewar praveenrewar merged commit 60a80de into carvel-dev:develop Aug 21, 2023
7 checks passed
@andrew-su andrew-su deleted the andrew-su/fix-kctrl-conditional branch September 11, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[kctrl] Declaring package-resources.yaml with missing "Package" resource causes index out of range error
2 participants