Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default API port to 8443 #1337

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Change default API port to 8443 #1337

merged 1 commit into from
Oct 18, 2023

Conversation

joaopapereira
Copy link
Member

What this PR does / why we need it:

Changes the default port that kapp-controller is listening at for API requests

Which issue(s) this PR fixes:

Fixes #1217

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

@joaopapereira
Change default API port to 8443
ff9e665 
Signed-off-by: João Pereira <joaod@vmware.com>
praveenrewar
praveenrewar approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@praveenrewar praveenrewar merged commit 1a63f5f into develop Oct 18, 2023
11 checks passed
@praveenrewar praveenrewar deleted the issue-1217 branch October 18, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenrewar praveenrewar praveenrewar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default port to 8443 instead of 10350
2 participants
@joaopapereira @praveenrewar