Enhance fallback to noop logic for apps to account for multiple namespaces #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100mik
force-pushed
the
fallback-to-noop-multi-ns
branch
2 times, most recently
from
7ecc8a9
to
0efe841
Compare
100mik
force-pushed
the
fallback-to-noop-multi-ns
branch
2 times, most recently
from
0b643f8
to
49f8af4
Compare
…paces Signed-off-by: Soumik Majumder <soumikm@vmware.com>
Signed-off-by: Soumik Majumder <soumikm@vmware.com>
100mik
force-pushed
the
fallback-to-noop-multi-ns
branch
from
49f8af4
to
1a8e8d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It ensures that Apps and PackageInstalls do not block namespace deletion when the app can safely fallback to
noopDeleteWhich issue(s) this PR fixes:
Fixes #1392
Review Checklist:
a link to that PR
change