Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting cli release package #1399

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Splitting cli release package #1399

merged 1 commit into from
Nov 15, 2023

Conversation

rohitagg2020
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
Copy link
Member

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohitagg2020 rohitagg2020 changed the title Breaking cli release package Splitting cli release package Nov 15, 2023
@rohitagg2020 rohitagg2020 merged commit b4886df into develop Nov 15, 2023
7 checks passed
@praveenrewar praveenrewar deleted the break-release-package branch November 15, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants