Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed e2e Tests Retry to iteration count #1453

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jignyasamishra
Copy link
Contributor

What this PR does / why we need it:

The retry function in e2e tests has been updated to use a counter instead of a time duration for retries

Which issue(s) this PR fixes:

Fixes #351

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


Signed-off-by: jignyasamishra <iamjignyasa@gmail.com>
@jignyasamishra
Copy link
Contributor Author

@praveenrewar @joe-kimmel-vmw Please review this PR. Thank you

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution @jignyasamishra!

@praveenrewar praveenrewar merged commit d8e83a8 into carvel-dev:develop Jan 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Change e2e Tests Retry to iteration count
2 participants