Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wait for App pause on package install pause if wait is disabled #1474

Merged
merged 1 commit into from Feb 7, 2024

Conversation

100mik
Copy link
Contributor

@100mik 100mik commented Feb 6, 2024

What this PR does / why we need it:

Allows users to update installed packages and pause and kick them even if they do not have access to App resources

Does this PR introduce a user-facing change?

Added wait flag to pause command
Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

Need to update docs to account for flag added to pause command

…d. Add wait flags to pkg i pause.

Signed-off-by: Soumik Majumder <soumikm@vmware.com>
@100mik
Copy link
Contributor Author

100mik commented Feb 7, 2024

@praveenrewar resolved the comments 🚀

@100mik 100mik merged commit 3c008c1 into carvel-dev:develop Feb 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants