Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the module name #1390 #1557

Merged
merged 1 commit into from
May 13, 2024
Merged

Update the module name #1390 #1557

merged 1 commit into from
May 13, 2024

Conversation

joaopapereira
Copy link
Member

What this PR does / why we need it: updates the module name to carvel.dev/kapp-controller and updates vendir to match the new module name

Which issue(s) this PR fixes:

Fixes #1378

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@joaopapereira joaopapereira mentioned this pull request Apr 30, 2024
5 tasks
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small optional nit, looks good otherwise.

pkg/fetch/vendir.go Show resolved Hide resolved
Signed-off-by: João Pereira <joaod@vmware.com>
@joaopapereira
Copy link
Member Author

When we release 0.52.0 we should merge the PR and create version 0.53.0

@praveenrewar
Copy link
Member

I was thinking that we should make a release now with this change. We currently have 3 commits after the last release, 2 of them are bumps and one of them is a fix for using kctrl as a library, so ideally one would want to bump to this release for those changes.
We could also wait, but then there's a chance that there will be merge conflicts on this PR and we would have to again spend some time on resolving them.

@joaopapereira
Copy link
Member Author

I am ok with releasing it. On Monday if y'll have some time can you release it and merge this PR?

@praveenrewar
Copy link
Member

Sure, I will do it.

@praveenrewar praveenrewar merged commit e081d6a into develop May 13, 2024
10 checks passed
@praveenrewar praveenrewar deleted the vanity-url-2 branch May 13, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use vanity urls to change the go module name
2 participants