Fix missing app deletion in app-group deploy #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes looks good to me. @praveenrewar, I believe we should have test cases around it to prevent similar issues in the future. |
praveenrewar
force-pushed
the
app-group-deploy
branch
from
a9d9e6d
to
2b23efb
Compare
|
@sethiyash I have added an e2e test for app-group deploy. |
Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
praveenrewar
force-pushed
the
app-group-deploy
branch
from
2b23efb
to
30ad7fc
Compare
sethiyash
approved these changes
Mar 28, 2024
rohitagg2020
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix missing app deletion during the kapp app-group deploy
Which issue(s) this PR fixes:
Fixes #908
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: