Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kbld commands are unable to work with insecure registries #44

Closed
ewrenn8 opened this issue Aug 28, 2020 · 3 comments
Closed

kbld commands are unable to work with insecure registries #44

ewrenn8 opened this issue Aug 28, 2020 · 3 comments
Assignees
@ewrenn8 @gcheadle-vmware
Labels
enhancement This issue is a feature request in progress Work has begun by a community member or a maintainer; this issue may be included in a future release

Comments

@ewrenn8
Copy link
Contributor

ewrenn8 commented Aug 28, 2020

Error message:

  Importing image as <some-wacky-registry>@sha256:41cdb94b4dbd0c70a8a31ccfc886b1451219e823e65bb6a4e1270263cf16eb04:
    Writing image:
      Retried 5 times:
        Get https://<some-wacky-registry>/v2/: http: server gave HTTP response to HTTPS client

Could support an --insecure-registry flag, which causes kbld to create a new registry with the insecure option, or just always include the option because ggcr will try https first then fallback on http.
@cppforlife
Copy link
Contributor

should be --registry-insecure so that it matches --registry-* prefix.

@cppforlife cppforlife added the enhancement This issue is a feature request label Aug 28, 2020
@ewrenn8 ewrenn8 added the in progress Work has begun by a community member or a maintainer; this issue may be included in a future release label Sep 1, 2020
@cppforlife cppforlife changed the title Kbld relocation commands are unable to upload to insecure registries kbld commands are unable to work with insecure registries Sep 2, 2020
@cppforlife
Copy link
Contributor

let's make this generic == apply to all commands.

pivotaljohn pushed a commit that referenced this issue Sep 8, 2020
@ewrenn8 @pivotaljohn
Add --registry-insecure flag for http registries
a84b2d2 
Solves: #44
- there were a couple of approaches considered. While this approach
  has a feel of a kind of "hack"...
  - parse a reference only to recreate one
  - override not just one option, but any option set by caller with
    the global defaults.
  ...it was also far less invasive than other approaches.

Co-authored-by: Eli Wrenn <ewrenn@pivotal.io>
Signed-off-by: Dmitriy Kalinin <cppforlife@gmail.com>
Signed-off-by: John Ryan <jtigger@infosysengr.com>
@cppforlife
Copy link
Contributor

included in https://github.com/k14s/kbld/releases/tag/v0.25.0

@cppforlife cppforlife mentioned this issue Sep 16, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewrenn8 ewrenn8

@gcheadle-vmware gcheadle-vmware

Labels
enhancement This issue is a feature request in progress Work has begun by a community member or a maintainer; this issue may be included in a future release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cppforlife @ewrenn8 @gcheadle-vmware