Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce SecretTemplates max exponential backoff #73

Merged
merged 1 commit into from Jun 9, 2022

Conversation

Samze
Copy link
Contributor

@Samze Samze commented Jun 8, 2022

  • The default controller exponential backoff is 1000*time.Second (16.6
    minutes)
  • SecretTemplate has input resources that may appear or change that may
    result in a successfuly reconcile. We therefore do not want to have to
    wait up until 16 minutes for this. Instead configure a max exponential
    backoff of 2 minutes.

closes #71

* The default controller exponential backoff is 1000*time.Second (16.6
minutes)
* SecretTemplate has input resources that may appear or change that may
result in a successfuly reconcile. We therefore do not want to have to
wait up until 16 minutes for this. Instead configure a max exponential
backoff of 2 minutes.
@Samze
Copy link
Contributor Author

Samze commented Jun 8, 2022

CI looks to be failing on an unrelated flake:

kapp: Error: Expected all resources to be gone, but found: secret/rsa-key1 (v1) namespace: default

@cppforlife cppforlife merged commit 51500ee into carvel-dev:develop Jun 9, 2022
@cppforlife
Copy link
Contributor

looking into flake separately.

@github-actions github-actions bot added the carvel-triage This issue has not yet been reviewed for validity label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-triage This issue has not yet been reviewed for validity cla-not-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing SecretTemplate with missing InputResources takes a long time to re-reconcile
3 participants