Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename module from "github.com/k14s/ytt" to "github.com/vmware-tanzu/carvel-ytt" #585

Closed
3 tasks done
pivotaljohn opened this issue Jan 14, 2022 · 5 comments
Closed
3 tasks done
Assignees
Labels
enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.

Comments

@pivotaljohn
Copy link
Contributor

pivotaljohn commented Jan 14, 2022

Describe the problem/challenge you have

We've now received multiple external requests to align the module name with the repo name, including:

Describe the solution you'd like
Rename the module and all references to it.

Anything else you would like to add:
This is part of vmware-tanzu/carvel#153


To Do:

  • Perform the rename
  • Give the Carvel repos a review (example: vmware-tanzu/carvel) to see if any repos are consuming ytt so that they can be updated.
  • broadcast this change in slack channels so that any consumers are aware.

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@pivotaljohn pivotaljohn added enhancement This issue is a feature request carvel triage This issue has not yet been triaged for relevance priority/important-soon Must be staffed and worked on currently or soon. and removed carvel triage This issue has not yet been triaged for relevance labels Jan 14, 2022
@pivotaljohn
Copy link
Contributor Author

important-soon: we've had more than one request for this. Placed in the backlog to be strategically occurring when little (no?) other work would be in flight (to minimize the potential for merge conflicts).

@aaronshurley
Copy link
Contributor

aaronshurley commented Jan 24, 2022

Let's make sure we broadcast this change in slack channels so that any consumers are aware.

Give the Carvel repos a review (example: vmware-tanzu/carvel) to see if any repos are consuming ytt so that they can be updated.

@gcheadle-vmware gcheadle-vmware self-assigned this Feb 15, 2022
@gcheadle-vmware
Copy link
Contributor

gcheadle-vmware commented Feb 16, 2022

Repos consuming ytt:


directory examples/integrating-with-ytt/internal-templating/ imports ytt v0.38.0 with module: github.com/k14s/ytt v0.38.0. Since v0.40.0 will be the first release with the new module name, this dependency will not need to be updated.

@gcheadle-vmware
Copy link
Contributor

gcheadle-vmware commented Feb 16, 2022

Previous slack message from Joao: https://vmware.slack.com/archives/CUK1X0Z8Q/p1643296774183100?thread_ts=1643253820.181400&cid=CUK1X0Z8Q

Slack message to go along with version ytt v0.40.0 release:

Hello ytt users 👋

As of the release of ytt v0.40.0, the go module has been renamed from github.com/k14s/ytt to github.com/vmware-tanzu/carvel-ytt so that it matches the repository name where it is stored. Since this might cause disruption in your workflow, v0.40.0 only contains the rename module change and has no feture difference with v0.39.0.


slack message for klt-private kapp team:
@ kapp With the upcoming release of ytt v0.40.0, the go module name has changed to github.com/vmware-tanzu/carvel-ytt . Currently kapp is using ytt v0.36.0 in its go.mod so this change should not impact you until you decide to update to v0.40.0.

@gcheadle-vmware
Copy link
Contributor

Completed in ytt v0.40.0

@github-actions github-actions bot added carvel triage This issue has not yet been triaged for relevance and removed carvel triage This issue has not yet been triaged for relevance labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.
Projects
None yet
Development

No branches or pull requests

3 participants