Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated given/when with if/elsif/else #30

Merged
merged 1 commit into from Nov 17, 2023

Conversation

gregoa
Copy link
Contributor

@gregoa gregoa commented Nov 17, 2023

In Debian we are currently applying the following patch to
Gtk3-ImageView.
We thought you might be interested in it too.

Description: Replace deprecated given/when with if/elsif/else
 given/when is deprecated since Perl 5.38 and will be removed in 5.42.
 In 5.38 it throws warnings:
 .
 given is deprecated at /build/libgtk3-imageview-perl-10/blib/lib/Gtk3/ImageView.pm line 179.
 when is deprecated at /build/libgtk3-imageview-perl-10/blib/lib/Gtk3/ImageView.pm line 180.
 when is deprecated at /build/libgtk3-imageview-perl-10/blib/lib/Gtk3/ImageView.pm line 184.
 when is deprecated at /build/libgtk3-imageview-perl-10/blib/lib/Gtk3/ImageView.pm line 189.
 when is deprecated at /build/libgtk3-imageview-perl-10/blib/lib/Gtk3/ImageView.pm line 200.
 when is deprecated at /build/libgtk3-imageview-perl-10/blib/lib/Gtk3/ImageView.pm line 204.
 when is deprecated at /build/libgtk3-imageview-perl-10/blib/lib/Gtk3/ImageView.pm line 208.
 when is deprecated at /build/libgtk3-imageview-perl-10/blib/lib/Gtk3/ImageView.pm line 216.
 when is deprecated at /build/libgtk3-imageview-perl-10/blib/lib/Gtk3/ImageView.pm line 237.
 given is deprecated at /build/libgtk3-imageview-perl-10/blib/lib/Gtk3/ImageView.pm line 615.
 when is deprecated at /build/libgtk3-imageview-perl-10/blib/lib/Gtk3/ImageView.pm line 616.
 when is deprecated at /build/libgtk3-imageview-perl-10/blib/lib/Gtk3/ImageView.pm line 619.
 .
 Use plain old if/elsif/else chains instead.
Origin: vendor
Bug-Debian: https://bugs.debian.org/1050445
Author: gregor herrmann <gregoa@debian.org>
Last-Update: 2023-11-17

The patch is tracked in our Git repository at
https://salsa.debian.org/perl-team/modules/packages/libgtk3-imageview-perl/raw/master/debian/patches/given_when.patch

Thanks for considering,
gregor herrmann,
Debian Perl Group

@DarthGandalf
Copy link
Collaborator

Thanks.

Linter failed, but the failure seems to be related to bitrot of CI setup, not to this PR. /action/lib/linter.sh: line 57: /action/lib/functions/tapLibrary.sh: No such file or directory

@DarthGandalf DarthGandalf merged commit 2e52110 into carygravel:master Nov 17, 2023
1 of 2 checks passed
@gregoa
Copy link
Contributor Author

gregoa commented Nov 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants